Messages in this thread | | | Date | Wed, 5 Nov 2014 14:29:59 -0800 | From | Greg KH <> | Subject | Re: [PATCH] phy: omap-usb2: Enable runtime PM of omap-usb2 phy properly |
| |
On Wed, Nov 05, 2014 at 06:54:23PM +0100, Sebastian Reichel wrote: > Hi, > > On Tue, Nov 04, 2014 at 11:47:06AM +0530, Kishon Vijay Abraham I wrote: > > From: Oussama Ghorbel <ghorbel@pivasoftware.com> > > > > The USB OTG port does not work since v3.16 on omap platform. > > This is a regression introduced by the commit > > eb82a3d846fa (phy: omap-usb2: Balance pm_runtime_enable() on probe failure > > and remove). > > This because the call to pm_runtime_enable() function is moved after the > > call to devm_phy_create() function, which has side effect since later in > > the subsequent calls of devm_phy_create() there is a check with > > pm_runtime_enabled() to configure few things. > > > > Signed-off-by: Oussama Ghorbel <ghorbel@pivasoftware.com> > > Tested-by: Rabin Vincent <rabin@rab.in> > > Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> > > stable annotations are missing. See > > Documentation/stable_kernel_rules.txt
I can take care of that, thanks.
greg k-h
| |