lkml.org 
[lkml]   [2014]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[PATCH 6/7] SELinux: The copy-up operation must have read permission on the lower file
From
Date
The copy-up operation must have read permission on the lower file for the task
that caused the copy-up. This helps prevent overlayfs from being used to
access something it shouldn't.

Signed-off-by: David Howells <dhowells@redhat.com>
---

security/selinux/hooks.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c
index f43f07fdc028..57f9c641779f 100644
--- a/security/selinux/hooks.c
+++ b/security/selinux/hooks.c
@@ -3144,7 +3144,8 @@ static void selinux_inode_getsecid(const struct inode *inode, u32 *secid)

static int selinux_inode_copy_up(struct dentry *src, struct dentry *dst)
{
- return 0;
+ const struct cred *cred = current_cred();
+ return dentry_has_perm(cred, src, FILE__OPEN | FILE__READ);
}

static int selinux_inode_copy_up_xattr(struct dentry *src, struct dentry *dst,


\
 
 \ /
  Last update: 2014-11-05 17:01    [W:2.327 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site