Messages in this thread | | | From | Andy Lutomirski <> | Date | Tue, 4 Nov 2014 12:25:47 -0800 | Subject | Re: [PATCH 0/4 v3] fs: Remove i_devices from struct inode |
| |
On Tue, Nov 4, 2014 at 12:20 PM, Al Viro <viro@zeniv.linux.org.uk> wrote: > On Tue, Nov 04, 2014 at 12:14:26PM -0800, Andy Lutomirski wrote: > >> Yeah, this idea clearly doesn't work. But I wonder whether the >> revised variant (which may be just moving cd_forget and bd_forget from >> evict to iput_final) would work. > > How the hell is it better? Neither of those will happen as long as dentry > is retained. And with /dev on tmpfs (which is bloody common) _that_ won't > happen until device node is unlinked...
It's by my misunderstanding of how inode refcounting works. The idea would be to drop the cdev reference when there are no non-VFS-internal references to the inode left.
| |