lkml.org 
[lkml]   [2014]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/4 v3] fs: Remove i_devices from struct inode
On Tue, Nov 04, 2014 at 11:52:22AM -0800, Andy Lutomirski wrote:

> Let me try again, though: what if a chardev inode replaced i_cdev with
> NULL and dropped its kobj reference in iput_final? This would add a
> bit over overhead to things that repeatedly open and close the same
> device node, but I doubt this matters much.

How is it different from what Jan proposed? The whole problem is that
iput_final() is too late. We could clean the reference on close, all
right, and have it looked up again on every open, but I'm not at all sure
that situation with opening/closing cdev is never a hot path, especially with
udev playing silly buggers, etc.


\
 
 \ /
  Last update: 2014-11-04 21:41    [W:0.054 / U:0.392 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site