Messages in this thread | | | Date | Tue, 04 Nov 2014 20:42:49 +0100 | From | Daniel Borkmann <> | Subject | Re: [PATCH 1/1 net-next] esp4: remove assignment in if condition |
| |
On 11/04/2014 08:28 PM, Fabian Frederick wrote: > Signed-off-by: Fabian Frederick <fabf@skynet.be> > --- > net/ipv4/esp4.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/net/ipv4/esp4.c b/net/ipv4/esp4.c > index 360b565..9dd66ee 100644 > --- a/net/ipv4/esp4.c > +++ b/net/ipv4/esp4.c > @@ -392,8 +392,11 @@ static int esp_input(struct xfrm_state *x, struct sk_buff *skb) > if (elen <= 0) > goto out; > > - if ((err = skb_cow_data(skb, 0, &trailer)) < 0) > + err = skb_cow_data(skb, 0, &trailer); > +
If you already feel the need to change this (?), then please don't add an extra newline here ...
> + if (err < 0) > goto out; > + > nfrags = err; > > assoclen = sizeof(*esph); >
| |