Messages in this thread | | | Subject | Re: [PATCH v8 3/5] amba: Don't unprepare the clocks if device driver wants IRQ safe runtime PM | From | Krzysztof Kozlowski <> | Date | Tue, 04 Nov 2014 08:59:29 +0100 |
| |
On pon, 2014-11-03 at 15:44 +0000, Russell King - ARM Linux wrote: > On Mon, Nov 03, 2014 at 10:41:02AM -0500, Alan Stern wrote: > > Bear in mind, however, that once the irq_safe flag has been set, the > > runtime PM core offers no way to turn it off again. > > Ah, I thought it did permit it to change both ways. In that case, we > don't need to validate that it doesn't change state on each call, and > we can just get away with checking its value.
It cannot be unset but still it could be *set* during runtime (not only in probe). However that shouldn't happen between suspend-resume calls, so the solution of undoing suspend's work seems fine.
I'll send a new patch doing this way. Without the wrapper.
Best regards, Krzysztof
| |