lkml.org 
[lkml]   [2014]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH usb v4 04/27] host: ehci-w90x900: remove duplicate check on resource
    Date
    From: Varka Bhadram <varkabhadram@gmail.com>

    Sanity check on resource happening with devm_ioremap_resource().

    Signed-off-by: Varka Bhadram <varkab@cdac.in>
    Acked-by: Alan Stern <stern@rowland.harvard.edu>
    ---
    drivers/usb/host/ehci-w90x900.c | 13 +++----------
    1 file changed, 3 insertions(+), 10 deletions(-)

    diff --git a/drivers/usb/host/ehci-w90x900.c b/drivers/usb/host/ehci-w90x900.c
    index a9303af..4717bf2 100644
    --- a/drivers/usb/host/ehci-w90x900.c
    +++ b/drivers/usb/host/ehci-w90x900.c
    @@ -42,27 +42,20 @@ static int usb_w90x900_probe(const struct hc_driver *driver,
    int retval = 0, irq;
    unsigned long val;

    -
    - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
    - if (!res) {
    - retval = -ENXIO;
    - goto err1;
    - }
    -
    hcd = usb_create_hcd(driver, &pdev->dev, "w90x900 EHCI");
    if (!hcd) {
    retval = -ENOMEM;
    goto err1;
    }

    - hcd->rsrc_start = res->start;
    - hcd->rsrc_len = resource_size(res);
    -
    + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
    hcd->regs = devm_ioremap_resource(&pdev->dev, res);
    if (IS_ERR(hcd->regs)) {
    retval = PTR_ERR(hcd->regs);
    goto err2;
    }
    + hcd->rsrc_start = res->start;
    + hcd->rsrc_len = resource_size(res);

    ehci = hcd_to_ehci(hcd);
    ehci->caps = hcd->regs;
    --
    1.7.9.5


    \
     
     \ /
      Last update: 2014-11-04 03:41    [W:4.110 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site