lkml.org 
[lkml]   [2014]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/8] perf tools: Rename dsos__write_buildid_table()
    Date
    The dsos__write_buildid_table() is not use struct dso and it mostly
    uses perf_session struct. So rename it to perf_session__write_buildid_
    table() so that it corresponds to other related functions such as
    perf_session__read_build_ids() and perf_session__cache_build_ids().

    Signed-off-by: Namhyung Kim <namhyung@kernel.org>
    ---
    tools/perf/util/header.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    diff --git a/tools/perf/util/header.c b/tools/perf/util/header.c
    index 0ecf4a304cbc..be8d02eb97e9 100644
    --- a/tools/perf/util/header.c
    +++ b/tools/perf/util/header.c
    @@ -297,10 +297,8 @@ static int machine__write_buildid_table(struct machine *machine, int fd)
    return err;
    }

    -static int dsos__write_buildid_table(struct perf_header *header, int fd)
    +static int perf_session__write_buildid_table(struct perf_session *session, int fd)
    {
    - struct perf_session *session = container_of(header,
    - struct perf_session, header);
    struct rb_node *nd;
    int err = machine__write_buildid_table(&session->machines.host, fd);

    @@ -523,7 +521,7 @@ static int write_build_id(int fd, struct perf_header *h,
    if (!perf_session__read_build_ids(session, true))
    return -1;

    - err = dsos__write_buildid_table(h, fd);
    + err = perf_session__write_buildid_table(session, fd);
    if (err < 0) {
    pr_debug("failed to write buildid table\n");
    return err;
    --
    2.1.2


    \
     
     \ /
      Last update: 2014-11-04 02:21    [W:4.268 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site