lkml.org 
[lkml]   [2014]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] HID: core: cleanup .claimed field on disconnect
On Mon, 3 Nov 2014, Benjamin Tissoires wrote:

> When a subdriver is rmmod-ed then re-insmod-ed, the hid device is not
> destroyed as it is owned by the transport layer.
> So when we re-probed the device, the hid device is assumed to be already
> claimed, and can lead to page faults if hid-core tries to forward the
> emitted data to the to-be-created claimed node.
>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> ---
>
> Hi Jiri,
>
> [keeping the people involved in the logitech-hidpp driver in CC]
>
> this one was particularly nasty. I had several page faults when just
> rmmod && insmod the hid-logitech-hidpp driver. The page fault was occuring
> in hidraw :/
> I was not able to get a stacktrace which I could include here. The laptop was
> completely unresponsive and I could take only a picture to debug it.

Thanks a lot for tracking it down, Benjamin, tricky one indeed. Queuing
for 3.18 still.

--
Jiri Kosina
SUSE Labs


\
 
 \ /
  Last update: 2014-11-04 00:01    [W:0.042 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site