| Date | Mon, 03 Nov 2014 16:48:34 +0100 | From | Javier Martinez Canillas <> | Subject | Re: [PATCH v4 03/14] regulator: of: Add regulator desc param to of_get_regulator_init_data() |
| |
On 11/03/2014 04:33 PM, Mark Brown wrote: > On Mon, Nov 03, 2014 at 03:40:38PM +0100, Javier Martinez Canillas wrote: > >> for_each_child_of_node(nproot, np) { >> if (!of_node_cmp(np->name, info->desc.name)) { >> config->init_data = >> - of_get_regulator_init_data(&pdev->dev, np); >> + of_get_regulator_init_data(&pdev->dev, np, >> + NULL); > > This looks buggy, we're not passing in a descriptor. >
The descriptor is only used when extracting the init_data to map the modes and since it was not a parameter before, some drivers needs to be refactored to pass that information.
I thought that instead of adding intrusive changes in drivers that I don't have hw to test, that parameter could be optional so the patch that use that information check if the descriptor and the map_modes function pointer are not NULL.
Best regards, Javier
|