lkml.org 
[lkml]   [2014]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH 4/4] [media] solo6x10: don't turn off/on encoder interrupt in processing loop
    Hi Andrey,

    On 10/29/2014 05:03 PM, Andrey Utkin wrote:
    > The used approach actually cannot prevent new encoder interrupt to
    > appear, because interrupt handler can execute in different thread, and
    > in current implementation there is still race condition regarding this.

    I don't understand what you mean with 'interrupt handler can execute in
    different thread'. Can you elaborate?

    Note that I do think that this change makes sense, but I do like to have a
    better explanation.

    Regards,

    Hans

    > Also from practice the code with this change seems to work as stable as
    > before.
    >
    > Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
    > ---
    > drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c | 2 --
    > 1 file changed, 2 deletions(-)
    >
    > diff --git a/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c b/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c
    > index b9b61b9..30e09d9 100644
    > --- a/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c
    > +++ b/drivers/media/pci/solo6x10/solo6x10-v4l2-enc.c
    > @@ -703,9 +703,7 @@ static int solo_ring_thread(void *data)
    >
    > if (timeout == -ERESTARTSYS || kthread_should_stop())
    > break;
    > - solo_irq_off(solo_dev, SOLO_IRQ_ENCODER);
    > solo_handle_ring(solo_dev);
    > - solo_irq_on(solo_dev, SOLO_IRQ_ENCODER);
    > try_to_freeze();
    > }
    >
    >



    \
     
     \ /
      Last update: 2014-11-03 16:21    [W:2.792 / U:0.300 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site