Messages in this thread | | | Date | Mon, 3 Nov 2014 15:48:56 +0100 | From | Mike Looijmans <> | Subject | Re: [PATCH v2] Add ltc3562 voltage regulator driver |
| |
On 11/03/2014 01:09 PM, Mark Brown wrote: > On Mon, Nov 03, 2014 at 09:10:08AM +0100, Mike Looijmans wrote: >> On 10/30/2014 05:51 PM, Mark Brown wrote: > >>>> + np_child = of_get_child_by_name(np_regulators, >>>> + ltc3562_regulators[i].name); >>>> + if (np_child == NULL) { > >>> Use the core support for looking up constraints please - set >>> regulators_node and so on. > >> I've been reworking the driver, but this is the only feedback comment I >> didn't quite understand. What is it that I'm expected to do here? Probably >> just the name of the method I'm supposed to call here would be enough. > > No function calls, just use regulators_node. What is unclear about the > functionality?
I don't understand what you mean by "regulators_node".
"grep -R regulators_node *" in the kernel source tree returns no results, nor does http://lxr.free-electrons.com/ident?i=regulators_node
Met vriendelijke groet / kind regards,
Mike Looijmans System Expert
TOPIC Embedded Systems Eindhovenseweg 32-C, NL-5683 KH Best Postbus 440, NL-5680 AK Best Telefoon: (+31) (0) 499 33 69 79 Telefax: (+31) (0) 499 33 69 70 E-mail: mike.looijmans@topic.nl Website: www.topic.nl
Please consider the environment before printing this e-mail
Topic zoekt gedreven (embedded) software specialisten! http://topic.nl/vacatures/topic-zoekt-software-engineers/
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |