Messages in this thread | | | Date | Mon, 3 Nov 2014 13:09:49 +0000 | From | Lee Jones <> | Subject | Re: [PATCH 1/1] mfd: intel_quark_i2c_gpio: Add Intel Quark X1000 I2C-GPIO MFD Driver |
| |
On Mon, 03 Nov 2014, Andy Shevchenko wrote:
> On Mon, 2014-11-03 at 15:39 +0800, Raymond Tan wrote: > > In Quark X1000, there's a single PCI device that provides both > > an I2C controller and a GPIO controller. This MFD driver will > > split the 2 devices for their respective drivers. > > > > This patch is based on Josef Ahmad's initial work for Quark enabling. > > Few comments below. > > After addressing take my > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
[...]
> > +static const struct i2c_mode_info platform_i2c_mode_info[] = { > > + { > > + .name = "Galileo", > > + .i2c_scl_freq = 100000, > > + }, > > + { > > + .name = "GalileoGen2", > > + .i2c_scl_freq = 400000, > > + }, > > You can decrease indentation level if you want to by using > > = {{ > }, { > }}; > > Though I don't know if Lee likes it :-)
No, please don't do that.
[...]
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |