Messages in this thread | | | Subject | Re: [PATCH v2 1/3] firmware loader: Introduce new API - request_firmware_abort() | From | Matt Fleming <> | Date | Mon, 3 Nov 2014 12:07:20 +0000 |
| |
On Mon, 2014-11-03 at 08:15 -0200, Henrique de Moraes Holschuh wrote: > On Mon, 03 Nov 2014, Kweh Hock Leong wrote: > > Note for people who use request_firmware_nowait(): > > You are required to do your own synchronization after you call > > request_firmware_abort() in order to continue unloading the > > module. The example synchronization code shows below: > > > > while (THIS_MODULE && module_refcount(THIS_MODULE)) > > msleep(20); > > This is _so_ asking for people to get it wrong, it is not funny :-(
Yeah. How about we make request_firmware_abort() synchronous so that drivers don't have to perform these reference counting games?
| |