lkml.org 
[lkml]   [2014]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2] x86, cpu: trivial printk formatting fixes
On Sun, Nov 02, 2014 at 11:56:42AM +0000, Steven Honeyman wrote:
> A 2 line printk makes dmesg output messy, because the second line does not get a timestamp.
> For example:
>
> [ 0.012863] CPU0: Thermal monitoring enabled (TM1)
> [ 0.012869] Last level iTLB entries: 4KB 1024, 2MB 1024, 4MB 1024
> Last level dTLB entries: 4KB 1024, 2MB 1024, 4MB 1024, 1GB 4
> [ 0.012958] Freeing SMP alternatives memory: 28K (ffffffff81d86000 - ffffffff81d8d000)
> [ 0.014961] dmar: Host address width 39
>
> V2: Revert change to log level, only fix the newline formatting issue
>
> Signed-off-by: Steven Honeyman <stevenhoneyman@gmail.com>

Yeah, patch is fine. I'm sorry that I forgot to ask you to add the
reasoning *why* this change is needed, i.e., all the details about dmesg
accessing /dev/kmsg directly and so on.

I think we want to explain why *really* this change is being done as
some old dmesg, as we saw, do work because they're using syslog(2) and
so on...

Thanks.

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--


\
 
 \ /
  Last update: 2014-11-03 11:41    [W:0.037 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site