Messages in this thread | | | Subject | Re: [PATCH v4] iio: iadc: Qualcomm SPMI PMIC current ADC driver | From | "Ivan T. Ivanov" <> | Date | Mon, 03 Nov 2014 10:45:03 +0200 |
| |
On Fri, 2014-10-31 at 21:48 +0100, Peter Meerwald wrote: > > Ivan T. Ivanov schrieb am 22.10.2014 16:13: > > > The current ADC is peripheral of Qualcomm SPMI PMIC chips. It has > > > 16 bits resolution and register space inside PMIC accessible across > > > SPMI bus. > > > > > > The driver registers itself through IIO interface. > > Pretty much there, just one question I would like to double-check: The CPU of these chips is > Little Endian, right? > > Annoyingly, you introduced a small typo in this revision, but that alone doesn't qualify for a > new revision. A separate patch fixing it would probably be best. See inline. > > some minor comments below
Thanks, will fix them. IIO maintainers, what do you prefer, new version or fallow-up patch?
Regards, Ivan
| |