Messages in this thread | | | Date | Mon, 3 Nov 2014 18:25:45 -0800 | From | Bjorn Andersson <> | Subject | Re: [PATCH v3 2/6] pinctrl: Introduce pinctrl driver for Qualcomm SSBI PMIC's |
| |
On Mon 03 Nov 00:48 PST 2014, Srinivas Kandagatla wrote:
> Hi Bjorn, > > On 20/08/14 23:13, Bjorn Andersson wrote: > > On Wed, Aug 20, 2014 at 2:28 PM, Bjorn Andersson > > <bjorn.andersson@sonymobile.com> wrote: > >> On Wed 20 Aug 01:06 PDT 2014, Srinivas Kandagatla wrote: > >>> 2> Looking back at v3.4 kernel, for gpio modes, BIT(0) of bank 0 is set > >>> to enable gpio mode. without this bit driver does not work for output pins. > >>> > >> > >> Thanks, I missed that. > >> > >> Unfortunately, setting that bit results in input not working - the interrupt > >> bits are never set for gpios that have that bit set. I'm trying to figure out > >> why this is the case before sending out the new version... > > > > With help from Andy Gross this is now corrected as well, turned out > > that BIT(0) in bank0 controls if the "direction" is considered. As I > > was tricked by the multiple levels of indirection in the codeaurora > > version I got these wrong. > > > > Will send out an updated version shortly. > Did you get a chance to spin a new version of this patcheset? >
Hi Srini,
Unfortunately it ended up on my todo list waiting for a discussion on irq_read_line(). As this seems to fall in place I will try to get this updated and sent out.
Sorry for the delays.
Regards, Bjorn
| |