Messages in this thread Patch in this message | | | Date | Sat, 29 Nov 2014 15:05:33 +0100 | From | SF Markus Elfring <> | Subject | [PATCH 1/1] net: cassini: Deletion of an unnecessary check before the function call "vfree" |
| |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Sat, 29 Nov 2014 14:34:59 +0100
The vfree() function performs also input parameter validation. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/net/ethernet/sun/cassini.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/sun/cassini.c b/drivers/net/ethernet/sun/cassini.c index 37f87ff..d745808 100644 --- a/drivers/net/ethernet/sun/cassini.c +++ b/drivers/net/ethernet/sun/cassini.c @@ -5179,8 +5179,7 @@ static void cas_remove_one(struct pci_dev *pdev) cp = netdev_priv(dev); unregister_netdev(dev); - if (cp->fw_data) - vfree(cp->fw_data); + vfree(cp->fw_data); mutex_lock(&cp->pm_mutex); cancel_work_sync(&cp->reset_task); -- 2.1.3
| |