Messages in this thread | | | Subject | Re: [PATCH v4 3/7] regulator: of: Parse ena-gpios property from DTS | From | Krzysztof Kozlowski <> | Date | Fri, 28 Nov 2014 10:19:56 +0100 |
| |
On czw, 2014-11-27 at 18:45 +0000, Mark Brown wrote: > On Thu, Nov 27, 2014 at 12:20:49PM +0100, Krzysztof Kozlowski wrote: > > > + constraints->ena_gpio = of_get_named_gpio_flags(np, "ena-gpios", 0, > > + &gpio_flags); > > + if (gpio_is_valid(constraints->ena_gpio)) { > > No, this isn't sensible - in what way would an enable control GPIO be a > constraint? The whole reason we have separate constraint and config > structures is that these are different things. Keep the GPIO setup in > the configuration.
OK, I'll change it to config.
Best regards, Krzysztof
| |