lkml.org 
[lkml]   [2014]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v6 02/46] virtio: use u32, not bitmap for features
On Thu, 27 Nov 2014 22:07:41 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> It seemed like a good idea to use bitmap for features
> in struct virtio_device, but it's actually a pain,
> and seems to become even more painful when we get more
> than 32 feature bits. Just change it to a u32 for now.
>
> Based on patch by Rusty.
>
> Suggested-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
> Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>

> diff --git a/drivers/virtio/virtio_pci.c b/drivers/virtio/virtio_pci.c
> index d34ebfa..ab95a4c 100644
> --- a/drivers/virtio/virtio_pci.c
> +++ b/drivers/virtio/virtio_pci.c
> @@ -120,8 +120,7 @@ static void vp_finalize_features(struct virtio_device *vdev)
> vring_transport_features(vdev);
>
> /* We only support 32 feature bits. */

I think you can kill this comment...

> - BUILD_BUG_ON(ARRAY_SIZE(vdev->features) != 1);
> - iowrite32(vdev->features[0], vp_dev->ioaddr+VIRTIO_PCI_GUEST_FEATURES);
> + iowrite32(vdev->features, vp_dev->ioaddr+VIRTIO_PCI_GUEST_FEATURES);

...and add blanks around '+', as you're touching this line anyway.

> }
>
> /* virtio config->get() implementation */

Reviewed-by: Cornelia Huck <cornelia.huck@de.ibm.com>



\
 
 \ /
  Last update: 2014-11-28 14:21    [W:0.271 / U:1.596 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site