lkml.org 
[lkml]   [2014]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 2/7] regulator: dt-bindings: Document the ena-gpios property
From
Date
On pią, 2014-11-28 at 11:21 +0000, Mark Brown wrote:
> On Fri, Nov 28, 2014 at 10:09:44AM +0100, Krzysztof Kozlowski wrote:
>
> > I understand your concerns here however I didn't want to overengineer
> > this. Is the same GPIO (on more complex PMICs) used in different
> > contexts? Like enable control and something more in the same time?
>
> Yes, and it's often reprogrammable at runtime.

I have doubts if generalized code could support such configuration...

>
> > Something like:
> > struct regulator_desc desc {
> > .name = "LDO1
> > .of_match = of_match_ptr("LDO1"),
> > .regulators_node = of_match_ptr("voltage-regulators"),
> > .ops = &max77686_ldo_ops,
> > + .of_ena_gpio = of_match_ptr("ena-gpios"),
> > ...
> > }
>
> Yes, and note that this also means existing bindings can use the core
> code.

Thanks for idea,
Krzysztof



\
 
 \ /
  Last update: 2014-11-28 13:21    [W:0.100 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site