Messages in this thread | | | Subject | Re: Re: [PATCH v10 2/2] ARM: kprobes: enable OPTPROBES for ARM 32 | From | "Jon Medhurst (Tixy)" <> | Date | Fri, 28 Nov 2014 11:17:36 +0000 |
| |
On Fri, 2014-11-28 at 11:13 +0000, Russell King - ARM Linux wrote: > On Fri, Nov 28, 2014 at 10:08:28AM +0000, Jon Medhurst (Tixy) wrote: > > On Fri, 2014-11-28 at 12:12 +0900, Masami Hiramatsu wrote: > > > (2014/11/27 23:36), Jon Medhurst (Tixy) wrote: > > [...] > > > > I thought it good to see what sort of benefits this code achieves, > > > > especially as it could grow quite complex over time, and the cost of > > > > that versus the benefit should be considered. > > > > > > I don't think it's so complex. It's actually cleanly separated. > > > However, ARM tree should have arch/arm/kernel/kprobe/ dir, > > > since there are too many kprobe related files under arch/arm/kernel/ ... > > > > Yes, that does seem like a good idea. Or rather a 'probes' directory to > > also include uprobes as that shares a lot of code with kprobes. > > If you want to do this, then please make it arch/arm/probes rather than > making the directory tree deeper than it needs to be.
Yes, good point.
-- Tixy
| |