lkml.org 
[lkml]   [2014]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ARM: EXYNOS: use u8 for val[] in struct exynos_pmu_conf
Hi Bartilomiej,


On Tuesday 08 July 2014 05:33 PM, Bartlomiej Zolnierkiewicz wrote:
> Values stored in val[] are never bigger than a byte.
>
> text data bss dec hex filename
> 5264 4 4 5272 1498 arch/arm/mach-exynos/pmu.o.before
> 2992 4 4 3000 bb8 arch/arm/mach-exynos/pmu.o.after
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>

I tested this patch and it's really helpful to reduce size.
How about resubmitting this change? As this will not get applied on
current tree.

Thanks,
Pankaj Dubey

> ---
> arch/arm/mach-exynos/common.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-exynos/common.h b/arch/arm/mach-exynos/common.h
> index b850db4..55ff019 100644
> --- a/arch/arm/mach-exynos/common.h
> +++ b/arch/arm/mach-exynos/common.h
> @@ -101,7 +101,7 @@ enum sys_powerdown {
>
> struct exynos_pmu_conf {
> void __iomem *reg;
> - unsigned int val[NUM_SYS_POWERDOWN];
> + u8 val[NUM_SYS_POWERDOWN];
> };
>
> extern void exynos_sys_powerdown_conf(enum sys_powerdown mode);
>


\
 
 \ /
  Last update: 2014-11-26 09:21    [W:0.110 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site