Messages in this thread | | | Date | Wed, 26 Nov 2014 06:14:22 -0800 | From | Andi Kleen <> | Subject | Re: perf/x86/intel/uncore: Add Haswell-EP uncore support |
| |
> I couldn't quickly decipher which MSRs we're writing to here in the SDM, > but are these really 64-bit wide registers that need 32 bits always set to zero ?
Yes the filter MSRs are only 32bit.
> I'm wondering if these should be just wrmsr's instead of wrmsrl's.
Can we just shut up coverity please?
wrmsr() is stupid and error prone and should have never been added as an interface.
-Andi -- ak@linux.intel.com -- Speaking for myself only
| |