lkml.org 
[lkml]   [2014]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: perf/x86/intel/uncore: Add Haswell-EP uncore support
> I couldn't quickly decipher which MSRs we're writing to here in the SDM,
> but are these really 64-bit wide registers that need 32 bits always set to zero ?

Yes the filter MSRs are only 32bit.

> I'm wondering if these should be just wrmsr's instead of wrmsrl's.

Can we just shut up coverity please?

wrmsr() is stupid and error prone and should have never been added as an
interface.

-Andi
--
ak@linux.intel.com -- Speaking for myself only


\
 
 \ /
  Last update: 2014-11-26 15:41    [W:0.116 / U:0.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site