Messages in this thread | | | Date | Tue, 25 Nov 2014 10:30:30 -0800 | From | Guenter Roeck <> | Subject | Re: [PATCH 1/5] hwmon: ina2xx: bail-out from ina2xx_probe() in case of configuration errors |
| |
On 11/25/2014 10:22 AM, Bartosz Golaszewski wrote: > 2014-11-25 18:59 GMT+01:00 Guenter Roeck <linux@roeck-us.net>: >> It seems to me this is a problem of your architecture. That doesn't >> make it a generic problem. Your architecture should detect that a >> probe was disconnected and de-instantiate the device automatically >> if so, and re-instantiate it if it is re-inserted. Ultimately this >> should be done with, for example, devicetree overlays. > > You're right and it's planned to be done this way in the future, when > this project exits its prototype phase (around Q2 2015). Nevertheless > I still think that if we're adding a set function, it should behave > like the getters and check the value returned by > i2c_smbus_write_word_swapped(). >
I do not question that. I question changing the return value to -ENODEV.
Repeating my earlier question: Is the resistor value changed by software or by changing the probe ?
Thanks, Guenter
| |