Messages in this thread | | | From | Stephan Mueller <> | Subject | Re: [PATCH v3 4/7] crypto: AF_ALG: add AEAD support | Date | Tue, 25 Nov 2014 16:08:35 +0100 |
| |
Am Dienstag, 25. November 2014, 22:58:50 schrieb Herbert Xu:
Hi Herbert,
>On Mon, Nov 24, 2014 at 03:58:34PM +0100, Stephan Mueller wrote: >> Ok. But in the code you see that skcipher is a 100% subset of AEAD. >> For AEAD, all we need to do in addition to normal symmetric ciphers >> is to select the AEAD kernel crypto API calls, to locate and use the >> AD and to ensure we have the right memory size to process the tag. > >There is still one fundamental difference between AEAD and ciphers. >Namely that ciphers can operate as you go while AEAD requests must >be done in one lot. So that should make the AEAD code simpler vs. >ciphers.
Yes, that is a key difference. > >I think the best course of action for now is to start with sharing >no code and then chop bits off as we see fit.
Ok, I will create a new patch set with a separate algif_aead.c. I guess the entire sgl handling logic will be gone in AEAD. > >Cheers,
Ciao Stephan
| |