Messages in this thread | | | Date | Tue, 25 Nov 2014 15:26:53 +0100 (CET) | From | Jiri Kosina <> | Subject | Re: [PATCH V2] HID: i2c-hid: fix race condition reading reports |
| |
On Mon, 24 Nov 2014, Benjamin Tissoires wrote:
> > Current driver uses a common buffer for reading reports either > > synchronously in i2c_hid_get_raw_report() and asynchronously in > > the interrupt handler. > > There is race condition if an interrupt arrives immediately after > > the report is received in i2c_hid_get_raw_report(); the common > > buffer is modified by the interrupt handler with the new report > > and then i2c_hid_get_raw_report() proceed using wrong data. > > > > Fix it by using a separate buffers for synchronous reports. > > > > Signed-off-by: Jean-Baptiste Maneyrol <jmaneyrol@invensense.com> > > [Antonio Borneo: cleanup, rebase to v3.17, submit mainline] > > Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com> > > Cc: stable@vger.kernel.org > > --- > > V1 -> V2 > > rename the synchronous buffer as rawbuf (instead of the > > asynchronous one) > > Sorry for the lag and thanks for resubmitting. > > This one is reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Applied, thanks.
-- Jiri Kosina SUSE Labs
| |