lkml.org 
[lkml]   [2014]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] GPU-DRM-MSM: Deletion of unnecessary checks before two function calls
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Tue, 25 Nov 2014 14:30:28 +0100

    The functions framebuffer_release() and vunmap() perform also input
    parameter validation. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/gpu/drm/msm/msm_fbdev.c | 3 +--
    drivers/gpu/drm/msm/msm_gem.c | 3 +--
    2 files changed, 2 insertions(+), 4 deletions(-)

    diff --git a/drivers/gpu/drm/msm/msm_fbdev.c b/drivers/gpu/drm/msm/msm_fbdev.c
    index ab5bfd2..fd5a6f3 100644
    --- a/drivers/gpu/drm/msm/msm_fbdev.c
    +++ b/drivers/gpu/drm/msm/msm_fbdev.c
    @@ -193,8 +193,7 @@ fail_unlock:
    fail:

    if (ret) {
    - if (fbi)
    - framebuffer_release(fbi);
    + framebuffer_release(fbi);
    if (fb) {
    drm_framebuffer_unregister_private(fb);
    drm_framebuffer_remove(fb);
    diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c
    index 4b1b82a..157cf21 100644
    --- a/drivers/gpu/drm/msm/msm_gem.c
    +++ b/drivers/gpu/drm/msm/msm_gem.c
    @@ -543,8 +543,7 @@ void msm_gem_free_object(struct drm_gem_object *obj)
    drm_free_large(msm_obj->pages);

    } else {
    - if (msm_obj->vaddr)
    - vunmap(msm_obj->vaddr);
    + vunmap(msm_obj->vaddr);
    put_pages(obj);
    }

    --
    2.1.3


    \
     
     \ /
      Last update: 2014-11-25 15:01    [W:4.189 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site