Messages in this thread | | | Date | Tue, 25 Nov 2014 09:01:22 +0100 | From | Uwe Kleine-König <> | Subject | Re: [PATCH] gpio: remove const modifier from gpiod_get_direction() |
| |
Hello Alexandre,
just some minor nitpicking on the commit log:
On Tue, Nov 25, 2014 at 04:20:45PM +0900, Alexandre Courbot wrote: > Although gpiod_get_direction() can be considered side-effect free for > consumers, its internals involve setting or clearing bits in the > affected GPIO descriptor, for which we need to force-cast the const > descriptor parameter. This could lead to incorrect behavior is the s/ is/ if/, and I think s/parameter/variable to non-const/
> compiler decide to optimize here, so remove this const parameter. The s/decide/decides/; s/parameter/attribute/
> intent is to make gpiod_get_direction() private anyway, so it does not > really matter. > > Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |