Messages in this thread Patch in this message | | | Subject | Re: [PATCH] staging: media: lirc: lirc_zilog.c: fix quoted strings split across lines | From | Joe Perches <> | Date | Tue, 25 Nov 2014 12:27:24 -0800 |
| |
On Tue, 2014-11-25 at 20:19 +0000, Luis de Bethencourt wrote: > checkpatch makes an exception to the 80-colum rule for quotes strings, and > Documentation/CodingStyle recommends not splitting quotes strings across lines > because it breaks the ability to grep for the string. Fixing these. [] > diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c [] > @@ -794,8 +792,7 @@ static int fw_load(struct IR_tx *tx) > if (!read_uint8(&data, tx_data->endp, &version)) > goto corrupt; > if (version != 1) { > - dev_err(tx->ir->l.dev, "unsupported code set file version (%u, expected" > - "1) -- please upgrade to a newer driver", > + dev_err(tx->ir->l.dev, "unsupported code set file version (%u, expected1) -- please upgrade to a newer driver", > version);
Hello Luis.
Please look at the strings being coalesced before submitting patches.
It's a fairly common defect to have either a missing space between the coalesced fragments or too many spaces.
It's almost certain that there should be a space between the "expected" and "1" here.
| |