Messages in this thread | | | Date | Mon, 24 Nov 2014 20:35:20 +0100 | Subject | Re: [PATCH] crypto: include crypto- module prefix in template | From | Mathias Krause <> |
| |
On 24 November 2014 at 20:17, Kees Cook <keescook@chromium.org> wrote: > This adds the module loading prefix "crypto-" to the template lookup > as well. > > For example, attempting to load 'vfat(blowfish)' via AF_ALG now correctly > includes the "crypto-" prefix at every level, correctly rejecting "vfat": > > net-pf-38 > algif-hash > crypto-vfat(blowfish) > crypto-vfat(blowfish)-all > crypto-vfat > > Reported-by: Mathias Krause <minipli@googlemail.com> > Signed-off-by: Kees Cook <keescook@chromium.org> > --- > crypto/algapi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
That commit will break the user API again as ciphers like 'cbc(aes)' won't work any more -- as the cbc module won't be loaded. You're missing the MODULE_ALIAS_CRYPTO() annotaions for all the crypto templates -- cbc, ctr, xts, hmac, ...
Regards, Mathias
| |