Messages in this thread | | | Date | Mon, 24 Nov 2014 10:17:50 +0000 | From | Al Viro <> | Subject | Re: [PATCH 17/17] rds: switch rds_message_copy_from_user() to iov_iter |
| |
On Mon, Nov 24, 2014 at 02:00:18AM +0000, Ben Hutchings wrote: > On Sat, 2014-11-22 at 04:39 +0000, Al Viro wrote: > [...] > > - ret = rds_page_copy_from_user(sg_page(sg), sg->offset + sg_off, > > - iov->iov_base + iov_off, > > - to_copy); > [...] > > It looks like rds_page_copy{,_from,_to}_user() are all unused after this > change, so you could delete them.
Maybe. Or maybe add a saner wrapper for rds_page_copy_from_user()... Separate story, anyway.
| |