lkml.org 
[lkml]   [2014]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 17/17] rds: switch rds_message_copy_from_user() to iov_iter
On Mon, Nov 24, 2014 at 02:00:18AM +0000, Ben Hutchings wrote:
> On Sat, 2014-11-22 at 04:39 +0000, Al Viro wrote:
> [...]
> > - ret = rds_page_copy_from_user(sg_page(sg), sg->offset + sg_off,
> > - iov->iov_base + iov_off,
> > - to_copy);
> [...]
>
> It looks like rds_page_copy{,_from,_to}_user() are all unused after this
> change, so you could delete them.

Maybe. Or maybe add a saner wrapper for rds_page_copy_from_user()... Separate
story, anyway.


\
 
 \ /
  Last update: 2014-11-24 11:41    [W:0.147 / U:1.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site