lkml.org 
[lkml]   [2014]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/1] backlight: lp8788: Deletion of an unnecessary check before the function call "backlight_device_unregister"
    On Sun, 23 Nov 2014, SF Markus Elfring wrote:

    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Sun, 23 Nov 2014 17:33:08 +0100
    >
    > The backlight_device_unregister() function tests whether its argument is NULL
    > and then returns immediately. Thus the test around the call is not needed.

    Also the $SUBJECT should be less than 75 chars.

    > This issue was detected by using the Coccinelle software.
    >
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    > ---
    > drivers/video/backlight/lp8788_bl.c | 3 +--
    > 1 file changed, 1 insertion(+), 2 deletions(-)
    >
    > diff --git a/drivers/video/backlight/lp8788_bl.c b/drivers/video/backlight/lp8788_bl.c
    > index d6c4f6a..24a055c 100644
    > --- a/drivers/video/backlight/lp8788_bl.c
    > +++ b/drivers/video/backlight/lp8788_bl.c
    > @@ -221,8 +221,7 @@ static void lp8788_backlight_unregister(struct lp8788_bl *bl)
    > {
    > struct backlight_device *bl_dev = bl->bl_dev;
    >
    > - if (bl_dev)
    > - backlight_device_unregister(bl_dev);
    > + backlight_device_unregister(bl_dev);
    > }
    >
    > static ssize_t lp8788_get_bl_ctl_mode(struct device *dev,

    --
    Lee Jones
    Linaro STMicroelectronics Landing Team Lead
    Linaro.org │ Open source software for ARM SoCs
    Follow Linaro: Facebook | Twitter | Blog
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2014-11-24 11:41    [W:4.151 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site