lkml.org 
[lkml]   [2014]   [Nov]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] x86: Intel Cache Allocation Technology support
Date


-----Original Message-----
From: Thomas Gleixner [mailto:tglx@linutronix.de]
Sent: Sunday, November 23, 2014 12:05 PM
To: Shivappa, Vikas
Cc: Vikas Shivappa; linux-kernel@vger.kernel.org; hpa@zytor.com; mingo@kernel.org; tj@kernel.org; matt.flemming@intel.com; Auld, Will; peterz@infradead.org
Subject: Re: [PATCH] x86: Intel Cache Allocation Technology support

On Fri, 21 Nov 2014, Vikas Shivappa wrote:
> On Fri, 21 Nov 2014, Thomas Gleixner wrote:
> > On Wed, 19 Nov 2014, Vikas Shivappa wrote:
> > > + rdmsr(IA32_PQR_ASSOC, l, h);
> >
> > Why on earth do we want to read an MSR on every context switch?
> > What's wrong with having
> >
> > DEFINE_PER_CPU(u64, cacheqe_pqr);
> >
> > u64 next_pqr, cur_pqr = this_cpu_read(cacheqe_pqr);
> >
> > cq = task_cacheqe(task);
> > next_pqr = cq ? cq->pqr : 0;
> >
> > if (next_pqr != cur_pqr) {
> > wrmsrl(IA32_PQR_ASSOC, next_pqr);
>
> when cqm(cache monitoring) and cqe are both running together , cant
> corrupt the low 32 bits, the rdmsr was a fix for that.
> If there are better alternatives at low cost , certainly acceptable

Sure there are. If cache monitoring and this runs together then they should better synchronize the cached PQR bits for the current cpu instead of enforcing useless MSR reads into the hot path.

What you provided is certainly unacceptable.

> > > +/* Create a new cacheqe cgroup.*/ static struct
> > > +cgroup_subsys_state * cqe_css_alloc(struct cgroup_subsys_state
> > > +*parent_css) {
> > > + struct cacheqe *parent = css_cacheqe(parent_css);
> > > + struct cacheqe *cq;
> > > +
> > > + /* This is the call before the feature is detected */
> >
> > Huch? We know at early boot that this is available. So why do you
> > need this? The first call to this should never happen before the
> > whole thing is initialized. If it happens, it's a design failure.
> >
> > > + if (!parent) {
> > > + root_cqe_group.clos = 0;
> > > + return &root_cqe_group.css;
> > > + }
> > > +
> > > + /* To check if cqe is enabled.*/
> > > + if (!cqe_genable)
> > > + return ERR_PTR(-ENODEV);
> >
> > So we first check for !parent and return &root_cqe_group.css and
> > later we return an error pointer? Really consistent behaviour.
>
> this is due to how the cgroup init works.

Sorry, I can't follow that argument. Why enforces the cgroup init this inconsistency? Why is cgroup init BEFORE we detect the feature?

Actually this can be fixed by disabling the earlyinit for the subsystem.. so the above order will be reversed meaning we first return error ptr

Thanks,
Vikas

Thanks,

tglx


\
 
 \ /
  Last update: 2014-11-24 11:21    [W:0.108 / U:1.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site