lkml.org 
[lkml]   [2014]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] video: fbdev-OMAP2: Deletion of unnecessary checks before the function call "i2c_put_adapter"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sun, 23 Nov 2014 14:07:22 +0100

    The i2c_put_adapter() function tests whether its argument is NULL
    and then returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/video/fbdev/omap2/displays-new/connector-dvi.c | 9 +++------
    1 file changed, 3 insertions(+), 6 deletions(-)

    diff --git a/drivers/video/fbdev/omap2/displays-new/connector-dvi.c b/drivers/video/fbdev/omap2/displays-new/connector-dvi.c
    index 74de2bc..196c61a 100644
    --- a/drivers/video/fbdev/omap2/displays-new/connector-dvi.c
    +++ b/drivers/video/fbdev/omap2/displays-new/connector-dvi.c
    @@ -262,8 +262,7 @@ static int dvic_probe_pdata(struct platform_device *pdev)

    in = omap_dss_find_output(pdata->source);
    if (in == NULL) {
    - if (ddata->i2c_adapter)
    - i2c_put_adapter(ddata->i2c_adapter);
    + i2c_put_adapter(ddata->i2c_adapter);

    dev_err(&pdev->dev, "Failed to find video source\n");
    return -EPROBE_DEFER;
    @@ -352,8 +351,7 @@ static int dvic_probe(struct platform_device *pdev)
    err_reg:
    omap_dss_put_device(ddata->in);

    - if (ddata->i2c_adapter)
    - i2c_put_adapter(ddata->i2c_adapter);
    + i2c_put_adapter(ddata->i2c_adapter);

    return r;
    }
    @@ -371,8 +369,7 @@ static int __exit dvic_remove(struct platform_device *pdev)

    omap_dss_put_device(in);

    - if (ddata->i2c_adapter)
    - i2c_put_adapter(ddata->i2c_adapter);
    + i2c_put_adapter(ddata->i2c_adapter);

    return 0;
    }
    --
    2.1.3


    \
     
     \ /
      Last update: 2014-11-23 14:41    [W:4.151 / U:0.888 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site