Messages in this thread Patch in this message | | | Date | Sat, 22 Nov 2014 17:00:21 +0100 | From | SF Markus Elfring <> | Subject | [PATCH 1/1] video: fbdev-LCDC: Deletion of an unnecessary check before the function call "vfree" |
| |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Sat, 22 Nov 2014 16:51:31 +0100
The vfree() function performs also input parameter validation. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/video/fbdev/sh_mobile_lcdcfb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/sh_mobile_lcdcfb.c index 2bcc84a..cfde21d 100644 --- a/drivers/video/fbdev/sh_mobile_lcdcfb.c +++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c @@ -2181,8 +2181,7 @@ sh_mobile_lcdc_channel_fb_cleanup(struct sh_mobile_lcdc_chan *ch) if (!info || !info->device) return; - if (ch->sglist) - vfree(ch->sglist); + vfree(ch->sglist); fb_dealloc_cmap(&info->cmap); framebuffer_release(info); -- 2.1.3
| |