Messages in this thread | | | Date | Fri, 21 Nov 2014 17:35:10 -0800 | Subject | Re: [GIT PULL] ftrace/x86: Add frames pointers to trampoline as necessary | From | Linus Torvalds <> |
| |
On Fri, Nov 21, 2014 at 6:50 AM, Steven Rostedt <rostedt@goodmis.org> wrote: > +.macro create_frame parent rip > +#ifdef CC_USING_FENTRY > + pushq \parent > + pushq %rbp > + movq %rsp, %rbp
This is a very strange frame.
Why do you do the "pushq \parent" at all? Why isn't this just a *real* frame and add it to MCOUNT_SAVE_FRAME.
You seem to create this fake frame-within-a-frame thing. It's not clear why.
Linus
| |