lkml.org 
[lkml]   [2014]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: frequent lockups in 3.18rc4
On Fri, 21 Nov 2014, Konrad Rzeszutek Wilk wrote:
> On Fri, Nov 21, 2014 at 08:51:43PM +0100, Thomas Gleixner wrote:
> > On Fri, 21 Nov 2014, Linus Torvalds wrote:
> > > Here's the simplified end result. Again, this is TOTALLY UNTESTED. I
> > > compiled it and verified that the code generation looks like what I'd
> > > have expected, but that's literally it.
> > >
> > > static noinline int vmalloc_fault(unsigned long address)
> > > {
> > > pgd_t *pgd_dst;
> > > pgdval_t pgd_entry;
> > > unsigned index = pgd_index(address);
> > >
> > > if (index < KERNEL_PGD_BOUNDARY)
> > > return -1;
> > >
> > > pgd_entry = init_mm.pgd[index].pgd;
> > > if (!pgd_entry)
> > > return -1;
> > >
> > > pgd_dst = __va(PAGE_MASK & read_cr3());
> > > pgd_dst += index;
> > >
> > > if (pgd_dst->pgd)
> > > return -1;
> > >
> > > ACCESS_ONCE(pgd_dst->pgd) = pgd_entry;
> >
> > This will break paravirt. set_pgd/set_pmd are paravirt functions.
> >
> > But I'm fine with breaking it, then you just need to change
> > CONFIG_PARAVIRT to 'def_bool n'
>
> That is not very nice.

Maybe not nice, but sensible.

Thanks,

tglx



\
 
 \ /
  Last update: 2014-11-22 03:01    [W:0.375 / U:3.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site