lkml.org 
[lkml]   [2014]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] [IA64] Deletion of unnecessary checks before the function call "unw_remove_unwind_table"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Fri, 21 Nov 2014 23:57:28 +0100

    The unw_remove_unwind_table() function performs also input parameter validation.
    Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    arch/ia64/kernel/module.c | 6 ++----
    1 file changed, 2 insertions(+), 4 deletions(-)

    diff --git a/arch/ia64/kernel/module.c b/arch/ia64/kernel/module.c
    index 24603be..30ff27d 100644
    --- a/arch/ia64/kernel/module.c
    +++ b/arch/ia64/kernel/module.c
    @@ -946,8 +946,6 @@ module_finalize (const Elf_Ehdr *hdr, const Elf_Shdr *sechdrs, struct module *mo
    void
    module_arch_cleanup (struct module *mod)
    {
    - if (mod->arch.init_unw_table)
    - unw_remove_unwind_table(mod->arch.init_unw_table);
    - if (mod->arch.core_unw_table)
    - unw_remove_unwind_table(mod->arch.core_unw_table);
    + unw_remove_unwind_table(mod->arch.init_unw_table);
    + unw_remove_unwind_table(mod->arch.core_unw_table);
    }
    --
    2.1.3


    \
     
     \ /
      Last update: 2014-11-22 00:41    [W:4.020 / U:9.248 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site