lkml.org 
[lkml]   [2014]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] sb_edac: Add support for Broadwell-DE processor
Date
>> +	{ PCI_DESCR(PCI_DEVICE_ID_INTEL_BROADWELL_IMC_HA0_TAD2, 1)	},
>> + { PCI_DESCR(PCI_DEVICE_ID_INTEL_BROADWELL_IMC_HA0_TAD3, 1) },
>
> You are marking TAD2 and TAD3 as optional here, but
>
>> + for (i = 0; i < NUM_CHANNELS; i++) {
>> + if (!pvt->pci_tad[i])
>> + goto enodev;
>> + }
>
> It's not optional here.

Heh. Cut & paste from the HASWELL version which has the same issue.
So we need to fix there too.

Thanks for the review.

-Tony


\
 
 \ /
  Last update: 2014-11-21 23:01    [W:0.069 / U:0.900 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site