lkml.org 
[lkml]   [2014]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] IDE: Deletion of an unnecessary check before the function call "module_put"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Fri, 21 Nov 2014 20:22:32 +0100

    The module_put() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/ide/ide.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/ide/ide.c b/drivers/ide/ide.c
    index 2ce6268..e29b02c 100644
    --- a/drivers/ide/ide.c
    +++ b/drivers/ide/ide.c
    @@ -101,8 +101,7 @@ void ide_device_put(ide_drive_t *drive)
    struct device *host_dev = drive->hwif->host->dev[0];
    struct module *module = host_dev ? host_dev->driver->owner : NULL;

    - if (module)
    - module_put(module);
    + module_put(module);
    #endif
    put_device(&drive->gendev);
    }
    --
    2.1.3


    \
     
     \ /
      Last update: 2014-11-21 21:01    [W:4.019 / U:5.604 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site