lkml.org 
[lkml]   [2014]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] media: pci: smipcie: Fix dependency for DVB_SMIPCIE
Em Fri, 21 Nov 2014 18:51:59 +0100
Andreas Ruprecht <rupran@einserver.de> escreveu:

> In smipcie.c, the function i2c_bit_add_bus() is called. This
> function is defined by the I2C bit-banging interfaces enabled
> with CONFIG_I2C_ALGOBIT.
>
> As there was no dependency in Kconfig, CONFIG_I2C_ALGOBIT could
> be set to "m" while CONFIG_DVB_SMIPCIE was set to "y", resulting
> in a build error due to an undefined reference. This patch adds
> the dependency on CONFIG_I2C_ALGOBIT in Kconfig.
>
> Signed-off-by: Andreas Ruprecht <rupran@einserver.de>
> Reported-by: Jim Davis <jim.epost@gmail.com>
> ---
> drivers/media/pci/smipcie/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/pci/smipcie/Kconfig b/drivers/media/pci/smipcie/Kconfig
> index 75a2992..c728721 100644
> --- a/drivers/media/pci/smipcie/Kconfig
> +++ b/drivers/media/pci/smipcie/Kconfig
> @@ -1,6 +1,6 @@
> config DVB_SMIPCIE
> tristate "SMI PCIe DVBSky cards"
> - depends on DVB_CORE && PCI && I2C
> + depends on DVB_CORE && PCI && I2C && I2C_ALGOBIT

IMHO, the best would be, instead, to select I2C_ALGOBIT.

> select DVB_M88DS3103 if MEDIA_SUBDRV_AUTOSELECT
> select MEDIA_TUNER_M88TS2022 if MEDIA_SUBDRV_AUTOSELECT
> select MEDIA_TUNER_M88RS6000T if MEDIA_SUBDRV_AUTOSELECT


\
 
 \ /
  Last update: 2014-11-21 19:41    [W:0.047 / U:4.628 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site