lkml.org 
[lkml]   [2014]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Btrfs: ctree: reduce args where only fs_info used
On Wed, Nov 12, 2014 at 01:43:09PM +0900, Daniel Dressler wrote:
> This patch is part of a larger project to cleanup
> btrfs's internal usage of struct btrfs_root. Many
> functions take btrfs_root only to grab a pointer
> to fs_info.

Thanks for picking up the project.

A mere formality, can you please justify the paragraphs to 74 chars?

--
This patch is part of a larger project to cleanup btrfs's internal usage
of struct btrfs_root. Many functions take btrfs_root only to grab a
pointer to fs_info.
--

> This patch does not address the two functions in
> ctree.c (insert_ptr, and split_item) which only
> use root for BUG_ONs in ctree.c
>
> This patch affects the following functions:
> 1) fixup_low_keys
> 2) btrfs_set_item_key_safe

Please send one patch per function change, unless there are more that
are somehow entangled that it would make it hard to separate.


\
 
 \ /
  Last update: 2014-11-21 17:41    [W:0.063 / U:2.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site