lkml.org 
[lkml]   [2014]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] USB-IP: Deletion of unnecessary checks before the function call "usb_put_dev"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Fri, 21 Nov 2014 16:33:18 +0100

    The usb_put_dev() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/usb/usbip/vhci_hcd.c | 9 +++------
    1 file changed, 3 insertions(+), 6 deletions(-)

    diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
    index c02374b..cc1b03e 100644
    --- a/drivers/usb/usbip/vhci_hcd.c
    +++ b/drivers/usb/usbip/vhci_hcd.c
    @@ -518,8 +518,7 @@ static int vhci_urb_enqueue(struct usb_hcd *hcd, struct urb *urb,
    dev_info(dev, "SetAddress Request (%d) to port %d\n",
    ctrlreq->wValue, vdev->rhport);

    - if (vdev->udev)
    - usb_put_dev(vdev->udev);
    + usb_put_dev(vdev->udev);
    vdev->udev = usb_get_dev(urb->dev);

    spin_lock(&vdev->ud.lock);
    @@ -539,8 +538,7 @@ static int vhci_urb_enqueue(struct usb_hcd *hcd, struct urb *urb,
    usbip_dbg_vhci_hc(
    "Not yet?:Get_Descriptor to device 0 (get max pipe size)\n");

    - if (vdev->udev)
    - usb_put_dev(vdev->udev);
    + usb_put_dev(vdev->udev);
    vdev->udev = usb_get_dev(urb->dev);
    goto out;

    @@ -831,8 +829,7 @@ static void vhci_device_reset(struct usbip_device *ud)
    vdev->speed = 0;
    vdev->devid = 0;

    - if (vdev->udev)
    - usb_put_dev(vdev->udev);
    + usb_put_dev(vdev->udev);
    vdev->udev = NULL;

    if (ud->tcp_socket) {
    --
    2.1.3


    \
     
     \ /
      Last update: 2014-11-21 17:21    [W:4.027 / U:10.892 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site