lkml.org 
[lkml]   [2014]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] USB: serial: Deletion of an unnecessary check before the function call "release_firmware"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Fri, 21 Nov 2014 16:15:34 +0100

    The release_firmware() function tests whether its argument is NULL
    and then returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/usb/serial/mxuport.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/usb/serial/mxuport.c b/drivers/usb/serial/mxuport.c
    index ab1d690..3653ec1 100644
    --- a/drivers/usb/serial/mxuport.c
    +++ b/drivers/usb/serial/mxuport.c
    @@ -1101,8 +1101,7 @@ static int mxuport_probe(struct usb_serial *serial,
    */
    usb_set_serial_data(serial, (void *)id->driver_info);
    out:
    - if (fw_p)
    - release_firmware(fw_p);
    + release_firmware(fw_p);
    return err;
    }

    --
    2.1.3


    \
     
     \ /
      Last update: 2014-11-21 17:01    [W:4.019 / U:10.912 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site