lkml.org 
[lkml]   [2014]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] USB-SIS: Deletion of an unnecessary check before the function call "usb_put_dev"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Fri, 21 Nov 2014 15:50:44 +0100

    The usb_put_dev() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/usb/misc/sisusbvga/sisusb.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/usb/misc/sisusbvga/sisusb.c b/drivers/usb/misc/sisusbvga/sisusb.c
    index 633caf6..022dc00 100644
    --- a/drivers/usb/misc/sisusbvga/sisusb.c
    +++ b/drivers/usb/misc/sisusbvga/sisusb.c
    @@ -2472,8 +2472,7 @@ sisusb_delete(struct kref *kref)
    if (!sisusb)
    return;

    - if (sisusb->sisusb_dev)
    - usb_put_dev(sisusb->sisusb_dev);
    + usb_put_dev(sisusb->sisusb_dev);

    sisusb->sisusb_dev = NULL;
    sisusb_free_buffers(sisusb);
    --
    2.1.3


    \
     
     \ /
      Last update: 2014-11-21 16:21    [W:4.031 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site