lkml.org 
[lkml]   [2014]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] USB: PCI-quirks: Deletion of unnecessary checks before the function call "pci_dev_put"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Fri, 21 Nov 2014 15:20:12 +0100

    The pci_dev_put() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/usb/host/pci-quirks.c | 12 ++++--------
    1 file changed, 4 insertions(+), 8 deletions(-)

    diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c
    index 2f3aceb..dd483c1 100644
    --- a/drivers/usb/host/pci-quirks.c
    +++ b/drivers/usb/host/pci-quirks.c
    @@ -233,10 +233,8 @@ commit:

    spin_unlock_irqrestore(&amd_lock, flags);

    - if (info.nb_dev)
    - pci_dev_put(info.nb_dev);
    - if (info.smbus_dev)
    - pci_dev_put(info.smbus_dev);
    + pci_dev_put(info.nb_dev);
    + pci_dev_put(info.smbus_dev);

    } else {
    /* no race - commit the result */
    @@ -447,10 +445,8 @@ void usb_amd_dev_put(void)

    spin_unlock_irqrestore(&amd_lock, flags);

    - if (nb)
    - pci_dev_put(nb);
    - if (smbus)
    - pci_dev_put(smbus);
    + pci_dev_put(nb);
    + pci_dev_put(smbus);
    }
    EXPORT_SYMBOL_GPL(usb_amd_dev_put);

    --
    2.1.3


    \
     
     \ /
      Last update: 2014-11-21 16:01    [W:4.029 / U:0.760 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site