Messages in this thread Patch in this message | | | From | "Aneesh Kumar K.V" <> | Subject | Re: [PATCH 03/10] mm: Convert p[te|md]_numa users to p[te|md]_protnone_numa | Date | Fri, 21 Nov 2014 10:58:34 +0530 |
| |
Mel Gorman <mgorman@suse.de> writes:
> Convert existing users of pte_numa and friends to the new helper. Note > that the kernel is broken after this patch is applied until the other > page table modifiers are also altered. This patch layout is to make > review easier. >
.....
> diff --git a/arch/powerpc/mm/pgtable.c b/arch/powerpc/mm/pgtable.c > index c90e602..b5d58d3 100644 > --- a/arch/powerpc/mm/pgtable.c > +++ b/arch/powerpc/mm/pgtable.c > @@ -173,7 +173,13 @@ void set_pte_at(struct mm_struct *mm, unsigned long addr, pte_t *ptep, > pte_t pte) > { > #ifdef CONFIG_DEBUG_VM > - WARN_ON(pte_val(*ptep) & _PAGE_PRESENT); > + /* > + * When handling numa faults, we already have the pte marked > + * _PAGE_PRESENT, but we can be sure that it is not in hpte. > + * Hence we can use set_pte_at for them. > + */ > + WARN_ON((pte_val(*ptep) & (_PAGE_PRESENT | _PAGE_USER)) == > + (_PAGE_PRESENT | _PAGE_USER)); > #endif
This can be VM_WARN_ON with #ifdef removed.
> /* Note: mm->context.id might not yet have been assigned as > * this context might not have been activated yet when this > diff --git a/arch/powerpc/mm/pgtable_64.c b/arch/powerpc/mm/pgtable_64.c
-aneesh
| |