lkml.org 
[lkml]   [2014]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/1] thermal: Exynos: Deletion of unnecessary checks before two function calls
    On Fri, 21 Nov 2014, SF Markus Elfring wrote:

    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Fri, 21 Nov 2014 11:06:33 +0100
    >
    > The functions cpufreq_cooling_unregister() and thermal_zone_device_unregister()
    > test whether their argument is NULL and then return immediately.
    > Thus the test around the call is not needed.
    >
    > This issue was detected by using the Coccinelle software.
    >
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    > ---
    > drivers/thermal/samsung/exynos_thermal_common.c | 6 ++----
    > 1 file changed, 2 insertions(+), 4 deletions(-)
    >
    > diff --git a/drivers/thermal/samsung/exynos_thermal_common.c b/drivers/thermal/samsung/exynos_thermal_common.c
    > index 3f5ad25..1cbb9d0 100644
    > --- a/drivers/thermal/samsung/exynos_thermal_common.c
    > +++ b/drivers/thermal/samsung/exynos_thermal_common.c
    > @@ -417,12 +417,10 @@ void exynos_unregister_thermal(struct thermal_sensor_conf *sensor_conf)
    >
    > th_zone = sensor_conf->pzone_data;
    >
    > - if (th_zone->therm_dev)
    > - thermal_zone_device_unregister(th_zone->therm_dev);
    > + thermal_zone_device_unregister(th_zone->therm_dev);
    >
    > for (i = 0; i < th_zone->cool_dev_size; i++) {
    > - if (th_zone->cool_dev[i])
    > - cpufreq_cooling_unregister(th_zone->cool_dev[i]);
    > + cpufreq_cooling_unregister(th_zone->cool_dev[i]);
    > }

    Now you have unnecessary {}

    julia

    >
    > dev_info(sensor_conf->dev,
    > --
    > 2.1.3
    >
    >


    \
     
     \ /
      Last update: 2014-11-21 11:41    [W:4.014 / U:1.412 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site