lkml.org 
[lkml]   [2014]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/1] target: Deletion of unnecessary checks before the function call "module_put"
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Fri, 21 Nov 2014 10:25:45 +0100

    The module_put() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/target/iscsi/iscsi_target_transport.c | 3 +--
    drivers/target/target_core_hba.c | 6 ++----
    2 files changed, 3 insertions(+), 6 deletions(-)

    diff --git a/drivers/target/iscsi/iscsi_target_transport.c b/drivers/target/iscsi/iscsi_target_transport.c
    index 882728f..08217d6 100644
    --- a/drivers/target/iscsi/iscsi_target_transport.c
    +++ b/drivers/target/iscsi/iscsi_target_transport.c
    @@ -26,8 +26,7 @@ struct iscsit_transport *iscsit_get_transport(int type)

    void iscsit_put_transport(struct iscsit_transport *t)
    {
    - if (t->owner)
    - module_put(t->owner);
    + module_put(t->owner);
    }

    int iscsit_register_transport(struct iscsit_transport *t)
    diff --git a/drivers/target/target_core_hba.c b/drivers/target/target_core_hba.c
    index a25051a..e6e496f 100644
    --- a/drivers/target/target_core_hba.c
    +++ b/drivers/target/target_core_hba.c
    @@ -137,8 +137,7 @@ core_alloc_hba(const char *plugin_name, u32 plugin_dep_id, u32 hba_flags)
    return hba;

    out_module_put:
    - if (hba->transport->owner)
    - module_put(hba->transport->owner);
    + module_put(hba->transport->owner);
    hba->transport = NULL;
    out_free_hba:
    kfree(hba);
    @@ -159,8 +158,7 @@ core_delete_hba(struct se_hba *hba)
    pr_debug("CORE_HBA[%d] - Detached HBA from Generic Target"
    " Core\n", hba->hba_id);

    - if (hba->transport->owner)
    - module_put(hba->transport->owner);
    + module_put(hba->transport->owner);

    hba->transport = NULL;
    kfree(hba);
    --
    2.1.3


    \
     
     \ /
      Last update: 2014-11-21 11:01    [W:4.220 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site